It's mostly a cleanup, but patch 4 allows kvm-i8259 to support "info pic" and "info irq" too.
I'm thinking whether it'll be good to move on this work to spread these commands to IOAPICs too, by removing "info ioapic" command and let "info pic" dump the things altogether (after all I think ioapic is also one type of PIC). Also, we can let ioapic to have statistics too. Let me know if anyone thinks this can be useful/cleaner and want me to continue (which won't need too much time for sure). Please review. Thanks, Peter Xu (5): i8259: convert DPRINTFs into trace i8259: use DEBUG_IRQ_COUNT always i8259: generalize statistics into common code kvm-i8259: support "info pic" and "info irq" i8259: move TYPE_INTERRUPT_STATS_PROVIDER upper hw/i386/kvm/i8259.c | 1 + hw/intc/i8259.c | 86 ++++++----------------------------------- hw/intc/i8259_common.c | 49 +++++++++++++++++++++++ hw/intc/trace-events | 7 ++++ include/hw/isa/i8259_internal.h | 7 +++- 5 files changed, 74 insertions(+), 76 deletions(-) -- 2.14.3