On 12/08/2017 10:14 AM, Peter Lieven wrote: > Am 08.12.2017 um 16:11 schrieb Eric Blake: >> On 12/08/2017 05:51 AM, Peter Lieven wrote: >>> we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task >>> hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in >>> some cases and handle it gracefully. This is the case for misaligned UNMAPs >> Is the block layer still capable of producing a misaligned UNMAP? If >> so, that's probably a bug in the block layer for not honoring the block >> limit geometries. > > In theory there should be none. I think we can drop this code.
Or, better yet, replace the check with an assert. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature