On 12/08/2017 05:51 AM, Peter Lieven wrote: > we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task > hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in > some cases and handle it gracefully. This is the case for misaligned UNMAPs
Is the block layer still capable of producing a misaligned UNMAP? If so, that's probably a bug in the block layer for not honoring the block limit geometries. > and WRITESAME10/16 calls without UNMAP. In this case a failure in the > logs can be quite misleading. > > While we are at it improve the logging to reveal which operation failed > at what LBA. > > Signed-off-by: Peter Lieven <p...@kamp.de> > --- > block/iscsi.c | 43 ++++++++++++++++++++++++++++++++----------- > 1 file changed, 32 insertions(+), 11 deletions(-) > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature