On 5/12/2017 6:19 PM, Eric Blake wrote:
On 12/05/2017 09:09 AM, Alberto Garcia wrote:
On Mon 20 Nov 2017 05:50:58 PM CET, Anton Nefedov wrote:
Signed-off-by: Anton Nefedov <anton.nefe...@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
qapi/block-core.json | 20 ++++++++++++++++++++
include/block/accounting.h | 1 +
block/qapi.c | 6 ++++++
3 files changed, 27 insertions(+)
Admittedtly this is just a style issue and I don't know what others
think, but wouldn't it be nicer if the documentation of new fields is
located together with the existing ones?
E.g
@rd_bytes
@wr_bytes
+@unmap_bytes
@rd_operations
@wr_operations
@flush_operations
+@unmap_operations
Grouping is fine, and your suggestion makes sense to me. One of the
nice things of QMP is that since it is name/value based, you don't have
to worry about inserting a name in the middle if that makes more sense
logically (it doesn't break backwards compatibility with old QMP
clients, the way that inserting something into the middle of a C struct
breaks all callers that were using the old struct layout).
Thank you, agree, will fix
/Anton
