On Wed, Nov 29, 2017 at 05:44:21PM -0500, John Snow wrote: > VPC has some difficulty creating geometries of particular size. > However, we can indeed force it to use a literal one, so let's > do that for the sake of test 197, which is testing some specific > offsets. > > Signed-off-by: John Snow <js...@redhat.com> > --- > tests/qemu-iotests/197 | 3 +++ > tests/qemu-iotests/common.filter | 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/197 b/tests/qemu-iotests/197 > index 887eb4f496..e1292689c1 100755 > --- a/tests/qemu-iotests/197 > +++ b/tests/qemu-iotests/197 > @@ -60,6 +60,9 @@ echo '=== Copy-on-read ===' > echo > > # Prep the images > +if [ "$IMGFMT" = "vpc" ]; then > + IMGOPTS=$(_optstr_add "$IMGOPTS" "force_size") > +fi
It would be nice to include a comment in the code instead of the commit description so anyone reading knows why vpc is special-cased here. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature