On 2017-11-10 16:51, Alberto Garcia wrote: > On Fri 10 Nov 2017 04:18:15 PM CET, Max Reitz wrote: >> On 2017-11-10 11:02, Alberto Garcia wrote: >>> On Thu 09 Nov 2017 09:30:24 PM CET, Max Reitz wrote: >>>> + echo > "$TEST_DIR/nbd-fault-injector.out" >>>> $PYTHON nbd-fault-injector.py $extra_args "$nbd_addr" >>>> "$TEST_DIR/nbd-fault-injector.conf" >"$TEST_DIR/nbd-fault-injector.out" >>>> 2>&1 & >>> >>> It seems that in this patch you're indenting with spaces but this file >>> uses tabs. >> >> Yes, but tabs are wrong. :-) > > I actually agree with you, but don't mix them in the file :-)
I can whistle and say here, too, that Eric liked it. O:-) And I really don't want to use tabs in the second hunk of this patch, as it's broken over two lines. Max
signature.asc
Description: OpenPGP digital signature