On 2017-11-09 21:58, Eric Blake wrote: > On 11/09/2017 02:30 PM, Max Reitz wrote: >> 083 has (at least) two issues: >> >> 1. By launching the nbd-fault-injector in background, it may not be >> scheduled until the first grep on its output file is executed. >> However, until then, that file may not have been created yet -- so it >> either does not exist yet (thus making the grep emit an error), or it >> does exist but contains stale data (thus making the rest of the test >> case work connect to a wrong address). >> Fix this by explicitly overwriting the output file before executing >> nbd-fault-injector. >> >> 2. The nbd-fault-injector prints things other than "Listening on...". >> It also prints a "Closing connection" message from time to time. We >> currently invoke sed on the whole file in the hope of it only >> containing the "Listening on..." line yet. That hope is sometimes >> shattered by the brutal reality of race conditions, so invoke grep >> before sed. > > Comment is now stale; s/invoke grep before sed/make the sed script more > robust/
*sigh* It appears my hope of easily fixing patches is often shattered by the brutal reality, too. > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks! I'll fix the sentence when applying the series. Max
signature.asc
Description: OpenPGP digital signature
