On Wed, Oct 25, 2017 at 12:45:10PM +1100, Alexey Kardashevskiy wrote: > On 25/10/17 03:27, Daniel P. Berrange wrote: > > On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kardashevskiy wrote: > >> The new git-submodule.sh script writes .git-submodule-status to > >> the source directory every time no matter what. This makes it conditional. > >> > >> Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> > >> --- > >> > >> I compile out of tree on a remote guest system where I mount the > >> source directory as "readonly" and build directory as "rw" and > >> scripts/git-submodule.sh tries writing to the source directory even when > >> I manually update modules on a host machine which is quite annoying. > >> > >> Is this something acceptable? Or I am missing something here? > > > > How did you update the modules - did you manually run 'git submodule > > update...' > > or did you use the git-submodule.sh script on your host machine ? > > > I run scripts/git-submodule.sh. Which is not thrilling either as I rather > expect source tree not to be affected in any way when running "make".
Oh, did you pass the list of sub-modules to it when running eg, ./scripts/git-submodule.sh update ui/keycodemapdb the list of submodules you need is printed in the configure output summary. > > If you run git-submodule.sh on the host, then it should save the status > > file, and then when you run make on the guest system, it should notice > > that you're already updated and never even invoke 'git-submodule.sh update' > > > scripts/git-submodule.sh also tries writing to the source directory (I > should probably have fixed that branch too) but this failure is not fatal > for "make" but makes it want to try "update" and then "make" fails. This shouldn't have happened in your case though, if you have already run 'git-submodule.sh update ...list of modules...' on the host machine, with the same list of modules that the guest 'configure' printed out. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
