On 24 October 2017 at 17:27, Daniel P. Berrange <berra...@redhat.com> wrote: > On Tue, Oct 24, 2017 at 07:58:53PM +1100, Alexey Kardashevskiy wrote: >> I compile out of tree on a remote guest system where I mount the >> source directory as "readonly" and build directory as "rw" and >> scripts/git-submodule.sh tries writing to the source directory even when >> I manually update modules on a host machine which is quite annoying. >> >> Is this something acceptable? Or I am missing something here? > > How did you update the modules - did you manually run 'git submodule > update...' > or did you use the git-submodule.sh script on your host machine ? > > If you run git-submodule.sh on the host, then it should save the status > file, and then when you run make on the guest system, it should notice > that you're already updated and never even invoke 'git-submodule.sh update' > > I'm not against your proposal below, but I'm curious why you're seeing > 'git-submodule.sh update' being run by make in the first place.
I don't think "git checkout on the fileserver, then build on the remote machine" is a particularly weird workflow. I'm starting to feel that the idea of doing git updates during "make" is not so good as it initially seemed; it's just not something that people expect to have happen during the build step. thanks -- PMM
