On Tue, Oct 17, 2017 at 08:37:42AM -0700, Richard Henderson wrote: > Do not require the submodule, but use it if present (in preference > even to a system copy). This will allow us to easily use capstone > in older systems for which a package is not available, and also > easily track bug fixes from upstream.
I don't like the idea that we should blindly use the submodule even if the host OS has it installed. This means developers working on git will never be testing against the capstone that will actually be used when they deploy a release build on their distro. It also gives inconsistent behaviour wrt the way the dtc module is handled, where we always try to use the system version and only try the submodule if the system version is missing. Thus I think we really ought to deal with capstone in the same way as dtc. We could make the check a little more advanced so that it checks for the particular capstone feature QEMU wants. That way if someone does have an outdated capstone we'd still use the submodule. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
