Hi, I'd like to check about the behavior of a QEMU instance when live migration is cancelled.
If the migration of a guest OS from source QEMU instance to destination instance is cancelled, the destination instance exits with a failure code. Could you please explain why this design decision was taken? I'm wondering if it's OK to change the behavior of the destination instance in this case. Would it be OK for the destination instance to not exit with the failure code, and instead retry processing incoming migration? I'm dealing with an internal bug report that's asking whether it would make more sense for the destination process to hang around for another attempt at migration than to be killed. We came across Peter's planned changes to migration postcopy[1] which indicate that migration-cancellation is planned to be enhanced during the postcopy phase. Are there any such enhancements planned for the active phase as well? I'd also like to know the difference between qemu_fclose() & qemu_file_shutdown(). The source instance currently uses the shutdown function to terminate the connection between source & destination. But it seems to disconnect the connection abruptly. Whereas fclose function seems to disconnect it more gracefully. When I dug deeper, I couldn't specifically tell the difference between the two. I'd like to know if I could substitute the shutdown function with fclose function in migrate_fd_cancel(). [1]: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05892.html Thanks! -- Jag
