On 11/10/2017 15:08, Peter Maydell wrote: >> Tracing is the right tool to detect bad guest code, and I think it makes >> sense to mark conditions that shouldn't happen with a correctly >> operating guest driver. I'm not sure if an exclamation mark is the best >> syntax for this, because I wouldn't have intuitively understood what >> it's supposed to tell me. > We have qemu_log_mask(LOG_GUEST_ERROR, ...) for logging guest errors, > so I think we should use that.
LOG_GUEST_ERROR is something different too. It means something that is undefined according to the data sheet more or less, such as accessing a non-existent reference. Here the driver does some validation of the values that were written in the registers, and tells the guest if the validation fails (by putting something in another registers). Using a tracepoint sounds like the right thing to do. Paolo
