Cool. Thanks for helping me through the process and for the great
feedback.
--
Brandon Carpenter | Software Engineer
Cypherpath, Inc.
400 Columbia Point Drive Ste 101 | Richland, Washington USA
Office: (650) 713-3060
On Thu, Sep 21, 2017 at 2:55 AM, Daniel P. Berrange
<berra...@redhat.com> wrote:
On Wed, Sep 20, 2017 at 09:56:07AM -0700, Brandon Carpenter wrote:
How are things looking, Daniel. I believe every comment from the
previous
version of the series was addressed.
I also wanted to mention that I put together a Python script, which
acts as
a proxy between noVNC and qemu, and can inject various frame types,
fragment
frames, and shutdown the socket in various ways to help exercise the
different code paths. I would be happy to post it here to help test
the
changes.
Sorry for the delay - I've reviewed this now and it looks good. I've
made a
few whitespace changes in places, but I've queued it for my next pull
request
now.
Regards,
Daniel
--
|: https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
https://fstop138.berrange.com :|
|: https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|
--
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is
for the sole use of the intended recipient(s) and may contain proprietary,
confidential or privileged information or otherwise be protected by law.
Any unauthorized review, use, disclosure or distribution is prohibited. If
you are not the intended recipient, please notify the sender and destroy
all copies and the original message.
