On Thu, Sep 14, 2017 at 04:14:33PM +0200, Greg Kurz wrote: > The script doesn't know about all possible types and learn them as > it parses the code. If it reaches a line with a type cast but the > type isn't known yet, it is misinterpreted as an identifier. > > For example the following line: > > foo = (hwaddr) -1; > > results in the following false-positive to be reported: > > ERROR: spaces required around that '-' (ctx:VxV) > > Let's add this standard QEMU type to the list of pre-known types. > > Signed-off-by: Greg Kurz <gr...@kaod.org>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
Not sure who should queue this, though.
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index fa478074b88d..def5bc1cc0e1 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -213,6 +213,7 @@ our @typeList = (
> qr{${Ident}_handler},
> qr{${Ident}_handler_fn},
> qr{target_(?:u)?long},
> + qr{hwaddr},
> );
>
> # This can be modified by sub possible. Since it can be empty, be careful
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
