On 7 September 2017 at 20:24, Subbaraya Sundeep <sundeep.l...@gmail.com> wrote:
> Emulated Emcraft's Smartfusion2 System On Module starter
> kit.
> +static void emcraft_sf2_machine_init(MachineClass *mc)
> +{
> + mc->desc = "SmartFusion2 SOM kit from Emcraft (M2S010)";
> + mc->init = emcraft_sf2_s2s010_init;
> + mc->ignore_memory_transaction_failures = true;
Please don't set ignore_memory_transaction_failures in new boards.
This is a legacy-old-code-only flag.
New boards should define enough devices, either properly
or using create_unimplemented_device(), to make whatever code
they're being tested against run.
This is a firm requirement for this code to go into master,
because once we let a board in with the flag set it's almost
impossible to clear it because we don't know what guest
code that previously worked on the board will now break.
thanks
-- PMM
