On Fri, Sep 1, 2017 at 1:52 PM, James Hogan <james.ho...@imgtec.com> wrote:
> On Fri, Sep 01, 2017 at 09:51:15AM -0700, Alistair Francis wrote:
>> diff --git a/target/mips/kvm.c b/target/mips/kvm.c
>> index 3317905e71..a23aa438d2 100644
>> --- a/target/mips/kvm.c
>> +++ b/target/mips/kvm.c
>> @@ -95,11 +95,11 @@ void kvm_mips_reset_vcpu(MIPSCPU *cpu)
>> CPUMIPSState *env = &cpu->env;
>>
>> if (!kvm_mips_fpu_cap && env->CP0_Config1 & (1 << CP0C1_FP)) {
>> - fprintf(stderr, "Warning: KVM does not support FPU, disabling\n");
>> + warn_report("KVM does not support FPU, disabling");
>> env->CP0_Config1 &= ~(1 << CP0C1_FP);
>> }
>> if (!kvm_mips_msa_cap && env->CP0_Config3 & (1 << CP0C3_MSAP)) {
>> - fprintf(stderr, "Warning: KVM does not support MSA, disabling\n");
>> + warn_report("KVM does not support MSA, disabling");
>> env->CP0_Config3 &= ~(1 << CP0C3_MSAP);
>> }
>
> That looks sensible.
> Reviewed-by: James Hogan <james.ho...@imgtec.com> [mips]
Thanks
>
> The 3 fprintfs in kvm_mips_update_state() are also pretty much non-fatal
> warnings too (though only because old kernels v3.10-v3.15 didn't
> implement the timer saving API). Feel free to convert those too if you
> like, otherwise I'll submit along with some other changes.
Ok, I'll add an extra patch to this series which converts those.
Thanks,
Alistair
>
> Cheers
> James
