I was going to queue most of this series except patch 02/11 due
the "qemu received signal" message log level, but a few conflicts
prevent the rest of the series from applying cleanly. Are you
planning to send v8?
On Fri, Aug 18, 2017 at 07:05:15PM +0200, Amador Pahim wrote:
> Changes v1->v2:
> - Style fixes to make checkpatch.pl happy.
> - Rebased.
> Changes v2->v3:
> - Fix typo in patch 3 ("qemu.py: make 'args' public") commit message.
> Changes v3->v4:
> - Squash the 2 first commits since they are co-dependant.
> - Cleanup launch() and shutdown().
> - Reorder the commits, putting the rename of self._args first.
> - Rebased.
> Changes v4->v5:
> - Break the cleanup commit into logical changes and include in the
> commit messages the rationale for making them.
> Changes v5->v6:
> - Remove the commit to rename self._args.
> - Fix is_running() return before first call to maunch().
> - Use python logging system.
> - Include the full command line on negative exit code error message.
> - Use os.path.null instead of /dev/null.
> - Improve the control over the created/deleted files.
> Changes v6->v7:
> - Split commits in self-contained/atomic changes.
> - Addressed the comments from previous version, basically improving the
> logging messages and the control over created files. See individual
> commit messages for details.
>
> Amador Pahim (11):
> qemu.py: fix is_running() return before first launch()
> qemu.py: avoid writing to stdout/stderr
> qemu.py: use os.path.null instead of /dev/null
> qemu.py: use poll() instead of 'returncode'
> qemu.py: cleanup redundant calls in launch()
> qemu.py: improve message on negative exit code
> qemu.py: include debug information on launch error
> qemu.py: make sure we only remove files we create
> qemu.py: launch vm only if it's not running
> qemu.py: don't launch again before shutdown()
> qemu.py: refactor launch()
>
> scripts/qemu.py | 141
> ++++++++++++++++++++++++++++++++++++++++++--------------
> 1 file changed, 106 insertions(+), 35 deletions(-)
>
> --
> 2.13.5
>
>
--
Eduardo
