On Wed, Aug 23, 2017 at 04:45:36PM +0200, Gerd Hoffmann wrote: > Hi, > > > > +(cd $source_path && git submodule update --init ui/keycodemapdb) > > > + > > > > Urgh, no, this won't work because of course you don't have to > > have a git checkout when running configure. > > > > Any suggestions on the "best" way to ensure that the ui/keycodemapdb > > git submodule is always checked out, without requiring developers to > > do something manually ? > > Don't require it? > > The updates shouldn't happen that frequently, IMO we should just commit > the generated files so checking out the submodule is only needed if you > work on the keycodemaps.
Ok, I guess that's simplest and matches what's done elsewhere in QEMU Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
