On Tue, Aug 22, 2017 at 09:24:16AM +0200, Markus Armbruster wrote: > John Snow <js...@redhat.com> writes: > > > On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > >> Hello guys, > >> > >> I'm reading the available python modules to exercise qemu and while > >> reading them > >> I fixed some issues that caught my attention. It usually starts with a > >> simple > >> pylint/docstring fixes and slowly graduates to more controversial ones so > >> I'm > >> open to suggestion to remove some of them. > >> > >> Kind regards, > >> Lukáš > >> > >> Changes in v2 > >> - Squashed 2nd and 10th patches into 2nd one > >> - Use repr() in MonitorResponseError's description > >> - Improved commit message of the 6th patch > >> - Two tweaks to docstrings changed in the 6th patch > >> - Also updated qmp-shell to use new-style super calls (7th patch) > >> - Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id patch) > >> - Changed the style of the style-fix in the 10th commit > >> > >> Changes in v3 > >> - Don't use repr in the 5th patch in MonitorResponseError > >> > >> Changes in v4 > >> - Use correct git base (remove unwanted commits) > >> > >> Changes in v5 > >> - Avoid bool comparison > >> - Change report to return in one docstring > >> - Removed the unnecessary spaces around single-line docstring > >> > >> Changes in v6 > >> - Bunch of docstring tweaks by Markus Armbruster > >> - Line break in <80 chars > >> - result dict => response dict > >> - Removed the "event_match" rename > >> > > > > Looks like all ten patches have an R-B despite changes; but it looks > > like nothing particularly major was changed anyway. > > > > Does this fall under Markus's jurisdiction? > > > > (Well, except for qtest.py which seemingly has double-extra-no > > maintainer...!) > > qemu.py is about starting and controlling QEMU, commonly for testing > purposes. It's related to QMP only by virtue of using QMP for control > (well, what else could it use?); if that makes me maintainer, I'll soon > maintain basically all tests :) > > As far as I can tell, qemu.py's main user is still qemu-iotests, via > qtest.py. Dan factored it out to make it available for > tests/migration/guestperf/. > > Options for maintaining qemu.py and qtest.py: > > * Maintain them with qemu-iotest > > Currently mainained with the block layer core, by Kevin and Max. > > - Keep it that way > > - Appoint qemu-iotest maintainer(s). > > * Maintain them separately, say as "Python qtest support", appoint > maintainer(s) > > Dan appears to be a hot contender: > > $ scripts/get_maintainer.pl -f --git-blame scripts/qtest.py > Fam Zheng <f...@redhat.com> (authored lines:71/110=65%,commits:1/3=33%) > "Daniel P. Berrange" <berra...@redhat.com> (authored > lines:39/110=35%,commits:2/3=67%) > Max Reitz <mre...@redhat.com> (commits:2/3=67%) > Amit Shah <amit.s...@redhat.com> (commits:1/3=33%) > Stefan Hajnoczi <stefa...@redhat.com> (commits:1/3=33%) > qemu-devel@nongnu.org (open list:All patches CC here) > $ scripts/get_maintainer.pl -f --git-blame scripts/qemu.py > "Daniel P. Berrange" <berra...@redhat.com> (authored > lines:217/229=95%,commits:2/4=50%) > Eduardo Habkost <ehabk...@redhat.com> (authored > lines:12/229=5%,commits:4/4=100%) > Markus Armbruster <arm...@redhat.com> (commits:1/4=25%) > Max Reitz <mre...@redhat.com> (commits:1/4=25%) > Amit Shah <amit.s...@redhat.com> (commits:1/4=25%) > qemu-devel@nongnu.org (open list:All patches CC here) > > Eduardo made the mistake^W^W^Wgraciously volunteered to maintain > scripts/qmp/qmp-shell, which is also used for testing. Perhaps he'd > be willing to maintain these guys as well.
I could take care of queueing patches for the Python modules on the same tree where qmp-shell patches would be queued. However, I would be happier if somebody else agreed to be listed as co-maintainer to at least help on review and decision-making. -- Eduardo
