On Tue, 23 Nov 2010 10:43:48 -0200
Luiz Capitulino <lcapitul...@redhat.com> wrote:
> On Tue, 23 Nov 2010 13:41:26 +0800
> Wen Congyang <we...@cn.fujitsu.com> wrote:
>
> > The args_type of migrate_set_speed in qmp-commands.hx is wrong.
> > When we set migrate speed by json, qemu will be core dumped.
> >
> > Signed-off-by: Wen Congyang
>
> Nice catch.
>
> Was caused by 07de3e60b05 and hence affects master only. Could you please
> mention that in the commit log? Also, your email address is missing
> in the signed-off-by line.
There's another problem there: we used to accept a json number but now we
accept only a json integer.
Markus, are you aware of this change?
>
> >
> > ---
> > qmp-commands.hx | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/qmp-commands.hx b/qmp-commands.hx
> > index 793cf1c..16bdb08 100644
> > --- a/qmp-commands.hx
> > +++ b/qmp-commands.hx
> > @@ -495,7 +495,7 @@ EQMP
> >
> > {
> > .name = "migrate_set_speed",
> > - .args_type = "value:f",
> > + .args_type = "value:o",
> > .params = "value",
> > .help = "set maximum speed (in bytes) for migrations",
> > .user_print = monitor_user_noop,
>
