On Mon, Jul 31, 2017 at 05:34:14PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > The bitmap setup during postcopy is incorrectly when the pgaes are huge
> > pages. Fix it.
> >
> > Signed-off-by: Peter Xu <pet...@redhat.com>
> > ---
> > migration/postcopy-ram.c | 2 +-
> > migration/ram.c | 8 ++++++++
> > migration/ram.h | 2 ++
> > 3 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> > index 276ce12..952b73a 100644
> > --- a/migration/postcopy-ram.c
> > +++ b/migration/postcopy-ram.c
> > @@ -578,7 +578,7 @@ static int qemu_ufd_copy_ioctl(int userfault_fd, void
> > *host_addr,
> > ret = ioctl(userfault_fd, UFFDIO_ZEROPAGE, &zero_struct);
> > }
> > if (!ret) {
> > - ramblock_recv_bitmap_set(host_addr, rb);
> > + ramblock_recv_bitmap_set_range(rb, host_addr, pagesize /
> > getpagesize());
>
> isn't that pagesize / qemu_target_page_size() ?
>
> Other than that it looks OK.
Yes, I should have fixed this before.
I guess Alexey will handle this change (along with the copied bitmap
series)? Anyway, I'll fix it as well in my series, until Alexey post
the new version that I can rebase to. Thanks,
--
Peter Xu
