Eric Blake <ebl...@redhat.com> writes: > On 07/28/2017 12:17 PM, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >>> COLOMode is defined in the QAPI schema, but not used there. Of the >>> stuff QAPI generates for it only the typedef is actually used. Use of >>> QAPI is pointless and only complicates things, so don't. >> >> Hmm, in one of the old COLO worlds I have, there's code to emit an event >> on exiting from COLO and that event includes the mode it was in. >> >> If the intent is to bring that or similar back then it would be worth >> keeping. > > We can always revert the removal once there is a user.
I assume YAGNI until proven otherwise. Posting patches putting COLOMode to use could serve as proof.
