>> +#include "qemu/osdep.h" >> +#include "qemu/log.h" >> +#include "qapi/error.h" >> +#include "target/ppc/cpu.h" >> +#include "sysemu/cpus.h" >> +#include "sysemu/dma.h" >> +#include "monitor/monitor.h" >> +#include "hw/ppc/xive.h" >> + >> +#include "xive-internal.h" >> + >> +/* >> + * Main XIVE object > > As with XICs, does it really make sense for there to be a "main" XIVE > object, or should be an interface attached to the machine?
yes. There are internal tables which are very specific to the controller and I don't think they belong to the machine. C.