On 06/29/2017 08:18 AM, Daniel P. Berrange wrote: > On Thu, Jun 29, 2017 at 10:05:13AM +0100, Peter Maydell wrote: >> On 28 June 2017 at 21:44, Khem Raj <raj.k...@gmail.com> wrote: >>> The ucontext_t type had a tag struct ucontext until now >>> but newer glibc will drop it so we need to adjust and use >>> the exposed type instead >> >> If true this seems like a bug in glibc to break >> existing working programs, and it should be fixed there... > > The glib commit message indicates it is intentional change, in order > to get POSIX compliance: > > > https://sourceware.org/git/?p=glibc.git;a=commit;h=251287734e89a52da3db682a8241eb6bccc050c9 > > NB, other parts of QEMU like the coroutine code are already > using the 'ucontext_t' typedef, so attaining consistency across > files is good regardless of the glibc change.
I agree. And since the issue has been reposted, I support the fix, although Nathaniel's repost may have the better commit message. https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg06005.html Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
