On Sun, 07/09 18:06, Peter Maydell wrote: > The function vmdk_read_cid() can fail if the read on the underlying > block device fails, or if there's a format error in the VMDK file. > However its API doesn't provide a mechanism to report these errors, > and in some cases we were returning a CID of 0 and in some cases a > CID of 0xffffffff, either of which might potentially be valid values. > > Change the function to return 0 on success or a negative errno, and > return the CID via a uint32_t* argument. Update the callsites to > handle and propagate the error appropriately. > > This fixes in passing a Coverity-spotted issue (CID 1350038) where > we weren't checking the return value from sscanf(). > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Fam Zheng <f...@redhat.com>
