Re: [Qemu-devel] [PATCH v11 25/29] target/arm: [tcg] Port to tb_stop

[Richard Henderson]

On 06/28/2017 06:57 AM, Lluís Vilanova wrote:

-    if (max_insns > TCG_MAX_INSNS) {
-        max_insns = TCG_MAX_INSNS;
+    if ((dc->base.tb->cflags & CF_LAST_IO) && dc->condjmp) {
+        /* FIXME: This can theoretically happen with self-modifying code. */
+        cpu_abort(cpu, "IO on conditional branch instruction");
      }

...

-        gen_io_end();
+    if (dc->base.tb->cflags & CF_LAST_IO && dc->condjmp) {
+        /* FIXME: This can theoretically happen with self-modifying code. */
+        cpu_abort(cpu, "IO on conditional branch instruction");

Two copies of this code... sequentially, apparently?


r~