Hi Alex,
On 05/17/2017 11:28 AM, Alex Bennée wrote:
v2:
- Addressed review feedback from Alex, added his R-B
- Fixed the "Problem with the SSL CA cert" problem while cloning from github.com
installing the ca-certificates package.
- Squashed/split some commits
- use 'apt-get clean' instead of brutal 'rm -rf'
- checked how many cores are available on Shippable and use them fully
(reduced total time from 44min to 38min)
- build armeb-linux-user target
Ping - is there a v3 coming with Fam's comments addressed?
I did address Fam's comment, I'm not sure about how Fam wanted to
document "where" extra files are copied to in the container's filesystem
but tried to improve what was here.
There is an issue when you add files with the ADD directive, if any file
is changed the script generates the same SHA1 hash and avoid to rebuild
the image, I added some lines to also consider per-file checksum, but
not for the shlibs case (I let a FIXME entry for that).
I then got stuck trying to improve `--include-executable`, I think the
correct way would be to use ldd to get linked libraries from the host,
then try to install them in the guest from the distrib packages, and
finally copy what can't be find in the guest.
But better let it for another serie.
Regards,
Phil.
