Eric Blake <ebl...@redhat.com> wrote: > On 05/17/2017 10:38 AM, Juan Quintela wrote: >> We have change in the previous patch to use migration capabilities for >> it. Notice that we continue using the old command line flags from >> migrate command from the time being. Remove the set_params method as >> now it is empty. >> >> For savevm, one can't do a: >> >> savevm -b/-i foo >> >> but now one can do: >> >> migrate_set_capability block on >> savevm foo >> >> And we can't use block migration. We could disable block capability >> unconditionally, but it would not be much better. >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> >> --- >> - Maintain shared/enabled dependency (Xu suggestion) >> - Now we maintain the dependency on the setter functions >> - improve error messages >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> > > This second S-o-b gets stripped, but the one that counts is in place > (I've made the same mistake before, as well - doing 'git commit --amend > -s' on a commit where I already had a --- separator)
And this time I *really* remove the -s from my git-format-patch alias. I dropped that last week on the terminal, rebooted the machine and ..... magic ... got the old alias O:-) > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks
