On Mon, May 08, 2017 at 03:54:18PM -0700, no-re...@patchew.org wrote:
[...]
> === OUTPUT BEGIN ===
> Checking PATCH 1/3: audio: Move arch_init audio code to hw/audio/soundhw.c...
> ERROR: suspect code indent for conditional statements (8, 13)
> #240: FILE: hw/audio/soundhw.c:76:
> + if (soundhw_count) {
> + printf("Valid sound card names (comma separated):\n");
>
> ERROR: suspect code indent for conditional statements (13, 17)
> #242: FILE: hw/audio/soundhw.c:78:
> + for (c = soundhw; c->name; ++c) {
> + printf ("%-11s %s\n", c->name, c->descr);
>
> ERROR: space prohibited between function name and open parenthesis '('
> #243: FILE: hw/audio/soundhw.c:79:
> + printf ("%-11s %s\n", c->name, c->descr);
>
> ERROR: else should follow close brace '}'
> #252: FILE: hw/audio/soundhw.c:88:
> + }
> + else {
>
> ERROR: else should follow close brace '}'
> #281: FILE: hw/audio/soundhw.c:117:
> + }
> + else {
>
> WARNING: line over 80 characters
> #299: FILE: hw/audio/soundhw.c:135:
> + ISABus *isa_bus = (ISABus *) object_resolve_path_type("", TYPE_ISA_BUS,
> NULL);
>
> WARNING: line over 80 characters
> #300: FILE: hw/audio/soundhw.c:136:
> + PCIBus *pci_bus = (PCIBus *) object_resolve_path_type("", TYPE_PCI_BUS,
> NULL);
>
> total: 5 errors, 2 warnings, 320 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
The style problems are not in new code, but in code being moved
to another file. If anybody wants to volunteer to fix those
issues, they should be addressed in follow-up patches.
--
Eduardo
