On 10/19/2010 04:15 PM, Stefan Weil wrote:
Am 19.10.2010 10:37, schrieb Michael S. Tsirkin:
On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote:
QEMU must only make sure that patching of the supported roms
with supported devices work.
I think that's what Anthony was saying too - make this depend
on a qdev property and set it only in eepro100 for now.
My new patch v3 implements something similar and does not need
a new qdev property:
I prefer to have an explicit property in case a user actually wants to
use this functionality. That said, if Michael's happy with the
approach, I'm okay with it too.
Regards,
Anthony Liguori
Don't patch because the rom file was defined by the user:
qemu -L pc-bios -boot n -netdev user,id=internet \
-device i82801,netdev=internet,romfile=gpxe-eepro100-80861209.rom
Patch because we work with the built-in default rom file:
qemu -L pc-bios -boot n -netdev user,id=internet \
-device i82801,netdev=internet
This is a safe solution which respects user's rom data
without adding much more complexity.
Regards,
Stefan
