amd-iommu and intel-iommu are really meant to be used with -device, so they need user_creatable=true. Remove the FIXME comment.
Cc: Marcel Apfelbaum <mar...@redhat.com> Cc: "Michael S. Tsirkin" <m...@redhat.com> Reviewed-by: Marcel Apfelbaum <mar...@redhat.com> Acked-by: Marcel Apfelbaum <mar...@redhat.com> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- Changes v1 -> v2: * (none) --- hw/i386/amd_iommu.c | 5 +---- hw/i386/intel_iommu.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 7b92c8c15a..efcc93cbfd 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data) dc->vmsd = &vmstate_amdvi; dc->hotpluggable = false; dc_class->realize = amdvi_realize; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ + /* Supported by the pc-q35-* machine types */ dc->user_creatable = true; } diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 54187a04a4..327a46cd19 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3009,10 +3009,7 @@ static void vtd_class_init(ObjectClass *klass, void *data) dc->hotpluggable = false; x86_class->realize = vtd_realize; x86_class->int_remap = vtd_int_remap; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ + /* Supported by the pc-q35-* machine types */ dc->user_creatable = true; } -- 2.11.0.259.g40922b1