David Gibson <da...@gibson.dropbear.id.au> wrote on 04/25/2017 11:34:41 PM:
Thanks for the review David. I'll send an updated patch soon with all your comments addressed and all other s/0/NULL or false/ as appropriate and a better commit message. Just to clarify my concern; the patch causes the QEMU openpic timer to be hard coded at 100MHZ. This is common, but the openpic spec has numerous ways the clock could be driven and the actual frequency depends on target board configuration. Given that no other users are apparently using the QEMU openpic timer, it is probably ok, but I did want to point out the deficiency.
