On Wed, Apr 19, 2017 at 11:52:45AM +0200, Igor Mammedov wrote: > On Wed, 12 Apr 2017 18:15:29 -0300 > Eduardo Habkost <ehabk...@redhat.com> wrote: > > > On Wed, Mar 22, 2017 at 02:32:35PM +0100, Igor Mammedov wrote: > > > Introduce machine_set_cpu_numa_node() helper that stores > > > node mapping for CPU in MachineState::possible_cpus. > > > CPU and node it belongs to is specified by 'props' argument. > > > > > > Patch doesn't remove old way of storing mapping in > > > numa_info[X].node_cpu as removing it at the same time > > > makes patch rather big. Instead it just mirrors mapping > > > in possible_cpus and follow up per target patches will > > > switch to possible_cpus and numa_info[X].node_cpu will > > > be removed once there isn't any users left. > > > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > > > So, this patch is the one that makes "-numa" and "-numa cpu" > > affect query-hotpluggable-cpus output. > that was intent behind series. > > [...] > > As noted in another message, I am not sure we really should make > > "-numa" affect query-hotpluggable-cpus output unconditionally (I > > believe we shouldn't). But we do, we need to document this very > > clearly. > What place would you suggest to document this at?
qemu-options.hx documentation for -numa cpu, NumaCpuOptions docs on qapi-schema, and/or query-hotpluggable-cpus docs on qapi-schema. -- Eduardo
