----- Original Message ----- > From: "Andrew Baumann" <andrew.baum...@microsoft.com> > To: "Paolo Bonzini" <pbonz...@redhat.com> > Cc: "Andrey Shedel" <ashe...@microsoft.com>, "Stefan Weil" > <s...@weilnetz.de>, qemu-devel@nongnu.org > Sent: Saturday, March 25, 2017 12:14:20 AM > Subject: Re: [Qemu-devel] [PATCH] win32: replace custom mutex and condition > variable with native primitives > > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > Sent: Friday, 24 March 2017 15:29 > > > > From: Andrey Shedel <ashe...@microsoft.com> > > > > > > The multithreaded TCG implementation exposed deadlocks in the win32 > > > condition variables: as implemented, qemu_cond_broadcast waited on > > > receivers, whereas the pthreads API it was intended to emulate does > > > not. This was causing a deadlock because broadcast was called while > > > holding the IO lock, as well as all possible waiters blocked on the > > > same lock. > > > > > > This patch replaces all the custom synchronisation code for mutexes > > > and condition variables with native Windows primitives (SRWlocks and > > > condition variables) with the same semantics as their POSIX > > > equivalents. To enable that, it requires a Windows Vista or newer host > > > OS. > > > > > > [AB: edited commit message] > > > Signed-off-by: Andrew Baumann <andrew.baum...@microsoft.com> > > > > Oops, just a nit but an important one: there should be a > > Signed-off-by for Andrey as well. > > Oops, my fault, since I took his code and prepared the patch submission. We > can resend with the signoff, but perhaps I should wait for a review?
It's enough if he replies with the Signed-off-by line. Paolo
