On Mon, Mar 13, 2017 at 02:55:20PM -0500, Eric Blake wrote: > hw/i386/trace-events has an amdvi_mmio_read trace that is used for > both normal reads (listing the register name, address, size, and > offset) and for an error case (abusing the register name to show > an error message, the address to show the maximum value supported, > then shoehorning address and size into the size and offset > parameters). The change from a wide address to a narrower size > parameter could truncate a (rather-large) bogus read attempt, so > it's better to create a separate dedicated trace with correct types, > rather than abusing the trace mechanism. Broken since its > introduction in commit d29a09c. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > hw/i386/amd_iommu.c | 3 +-- > hw/i386/trace-events | 1 + > 2 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to my tracing-next tree: https://github.com/stefanha/qemu/commits/tracing-next Stefan
signature.asc
Description: PGP signature
