On Wed, 8 Mar 2017 09:26:58 +0100
Julian Kirsch <g...@kirschju.re> wrote:
[...]
> >
> >> +++ b/qapi-schema.json
> >> @@ -2365,6 +2365,55 @@
> >> 'data': {'val': 'int', 'size': 'int', 'filename': 'str'} }
> >>
> >> ##
> >> +# @MsrInfo:
> >> +#
> >> +# Information about a MSR
> >> +#
> >> +# @cpu_idx: CPU index
we are trying no to use cpu_index in outside interfaces and
make it disappear from there.
It's possible to use qom-path instead or more natural
CpuInstanceProperties to specify a CPU.
PS:
Comment applies to all QMP/monitor commands/structures introduced
in this patch.
> >> +# @msr_idx: MSR index
> >> +#
> >> +# @value: MSR value
> >> +#
> >> +# Since: 2.8.1
> >
> > You've missed 2.8 by a long shot; you've even missed soft freeze for
> > 2.9. This should be 2.10.
> >
>
> Ops. thanks for pointing this out, will update it. I sticked to the latest
> version returned by "git tag".
>
> >> +##
> >> +{ 'struct': 'MsrInfo',
> >> + 'data': {'cpu_idx': 'int', 'msr_idx': 'uint32', 'value': 'uint64'} }
> >
> > Please spell new members with '-' rather than '_', as in 'cpu-idx' (or
> > even spell it out as 'cpu-index') and 'msr-idx'.
> >
>
> Again, thank you, will take care of it.
>
> >> +
> >> +##
> >> +# @msr-set:
> >> +#
> >> +# Set model specific registers (MSRs) on x86
> >> +#
> >> +# @cpu_idx: CPU holding the MSR that should be written
> >> +#
> >> +# @msr_idx: MSR index to write
> >> +#
> >> +# @value: Value to write
> >> +#
> >> +# Returns: Nothing on success
> >
> > Useless Returns: line.
> >
>
> Removed.
>
> Best,
> Julian
>
