On 09.03.2017 18:27, Eduardo Habkost wrote: > On Thu, Mar 09, 2017 at 05:32:08PM +0100, Paolo Bonzini wrote: >> >> >> On 08/03/2017 19:44, Eduardo Habkost wrote: >>>>> If it's only supported by x86, I would just move the >>>>> implementation to a x86-specific file, and add a stub for the >>>>> other architectures. See qmp_query_gic_capabilities() for an >>>>> example. >>>>> >>>>> Also, the command should be added to >>>>> qmp_unregister_commands_hack() so we don't even report it as >>>>> available on other architectures. >>>>> >>>> Awesome, thanks for your comments, I'll move the qmp commands to >>>> target/i386/monitor.c and unregister them for architectures other than >>>> I386. Do >>>> I have to explicitly take care of unregistering the hmp commands as well? >>> For HMP commands, it looks like you can simply use #ifdefs inside >>> hmp-commands.hx. >> >> Do we need the QMP commands? There is no QMP version of info registers, >> for example. > > Good point. If we really want to expose additional CPU info > through QMP, we already have qom_path on 'query-cpus', which > allows QOM properties to be queried directly from the CPU object. >
Good catch. Will look into it. -Julian
