On Thu, Feb 09, 2017 at 04:27:07PM -0800, ashish mittal wrote: > On Thu, Feb 9, 2017 at 10:45 AM, ashish mittal <ashmit...@gmail.com> wrote: > > On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal <ashmit...@gmail.com> wrote: > >> On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody <jc...@redhat.com> wrote: > >>> On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: > >>>> On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody <jc...@redhat.com> wrote: > >>>> > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > >>>> >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody <jc...@redhat.com> wrote: > >>>> >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: > >>>> >> >> From: Ashish Mittal <ashish.mit...@veritas.com> > >>>> >> >> > >>>> >> >> Source code for the qnio library that this code loads can be > >>>> >> >> downloaded from: > >>>> >> >> https://github.com/VeritasHyperScale/libqnio.git > >>>> >> >> > >>>> >> >> Sample command line using JSON syntax: > >>>> >> >> ./x86_64-softmmu/qemu-system-x86_64 -name instance-00000008 -S > >>>> >> >> -vnc 0.0.0.0:0 > >>>> >> >> -k en-us -vga cirrus -device > >>>> >> >> virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 > >>>> >> >> -msg timestamp=on > >>>> >> >> 'json:{"driver":"vxhs","vdisk-id":"c3e9095a-a5ee-4dce-afeb-2a59fb387410", > >>>> >> >> "server":{"host":"172.172.17.4","port":"9999"}}' > >>>> >> >> > >>>> >> >> Sample command line using URI syntax: > >>>> >> >> qemu-img convert -f raw -O raw -n > >>>> >> >> /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad > >>>> >> >> vxhs://192.168.0.1:9999/c6718f6b-0401-441d-a8c3-1f0064d75ee0 > >>>> >> >> > >>>> >> > > >>>> >> > I don't know if I am using the qnio_server test server correctly or > >>>> >> > not, but > >>>> >> > when I run qemu-io from the command line I get an i/o error. When > >>>> >> > I run the > >>>> >> > qemu-iotests, I get a segfault. > >>>> >> > > >>>> >> > Were you able to run qemu-iotests with these patches? > >>>> >> > > >>>> >> > Here is how I am invoking qnio_server: > >>>> >> > > >>>> >> > # qnio_server -d > >>>> >> > /home/jcody/work/redhat/upstream/qemu-kvm/tests/qemu-iotests/scratch > >>>> >> > -v > >>>> >> > > >>>> >> > > >>>> >> > >>>> >> I ran full qemu-iotests and qemu-io manually with the test server on > >>>> >> version 7 patches. Ran qemu-io manually with the test server on > >>>> >> version 8, but the libvxhs code is undergoing a lot of checkins. Will > >>>> >> test again tomorrow and get back. > >>>> >> > >>>> > > >>>> > Does my invocation above look correct, for running the qemu-iotests? > >>>> > >>>> qemu-iotest starts the server internally. The server does not have to > >>>> be started explicitly before running qemu-iotest. The server must not > >>>> be running before you begin the test because then the tests would > >>>> find port 9999 busy. > >>>> Running make install on libvxhs copies the test server to the location > >>>> where the qemu-iotests expect to find it. > >>> > >>> > >>> OK, thanks. I tried that too, and I also tried against the branch > >>> "ashish_securify_changes" for libqnio. I still have qemu-iotests giving > >>> me > >>> a segfault. > >>> > >>> > >> > >> Qemu patch v7 and v8 do not have many changes. I did successfully run > >> iotests with v7 and libqnio master. I'm guessing there could be > >> something in the 'securify' library branch that's causing this. I will > >> rebuild and retest. > > > > Confirmed that there is a problem and qemu-iotest is segfaulting. Will > > get back with a fix. > > Checked in some changes to libqnio. Could you please try it again with > the latest 'securify' branch?
Thanks - I just tried it, and can confirm that all 26 tests pass with raw: # ./check -vxhs -raw [...] Passed all 26 tests -Jeff
