On Sat, Feb 18, 2017 at 12:30:31AM +0000, Ketan Nilangekar wrote: > On 2/17/17, 1:42 PM, "Jeff Cody" <jc...@redhat.com> wrote: > > On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > > Hi, > > > > I am getting the following error with checkpatch.pl > > > > ERROR: externs should be avoided in .c files > > #78: FILE: block/vxhs.c:28: > > +QemuUUID qemu_uuid __attribute__ ((weak)); > > > > Is there any way to get around this, or does it mean that I would have > > to add a vxhs.h just for this one entry? > > > > I remain skeptical on the use of the qemu_uuid as a way to select the TLS > cert. > > [ketan] > Is there another identity that can be used for uniquely identifying instances? > The requirement was to enforce vdisk access to owner instances.
The qemu_uuid weak attribute looks suspect. What is going to provide a strong qemu_uuid symbol? Why aren't configuration parameters like the UUID coming from the QEMU command-line? Stefan
signature.asc
Description: PGP signature
