On 2017年02月07日 14:16, Peter Xu wrote:
On Tue, Feb 07, 2017 at 01:27:37PM +0800, Jason Wang wrote:
On 2017年02月03日 16:22, Peter Xu wrote:
There are lots of places in current intel_iommu.c codes that named
"iova" as "gpa". It is really confusing to use a name "gpa" in these
places (which is very easily to be understood as "Guest Physical
Address", while it's not). To make the codes (much) easier to be read, I
decided to do this once and for all.
No functional change is made. Only literal ones.
Signed-off-by: Peter Xu <pet...@redhat.com>
Reviewed-by: Jason Wang <jasow...@redhat.com>
Actually, there's one more left:
$git grep gpa hw/i386/intel_iommu.c
hw/i386/intel_iommu.c:static int vtd_gpa_to_slpte(VTDContextEntry *ce,
uint64_t iova, bool is_write,
hw/i386/intel_iommu.c: ret_fr = vtd_gpa_to_slpte(&ce, addr, is_write,
&slpte, &level,
Yes, will fix this as well. Thanks,
-- peterx
You can keep my Reviewed-by with this fixed.
Thanks
