Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [RFC PATCH v0] softfloat: Add
float128_to_uint64_round_to_zero()
Message-id: 1485946146-21639-1-git-send-email-bhar...@linux.vnet.ibm.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/1485946146-21639-1-git-send-email-bhar...@linux.vnet.ibm.com ->
patchew/1485946146-21639-1-git-send-email-bhar...@linux.vnet.ibm.com
Switched to a new branch 'test'
7d6d31a softfloat: Add float128_to_uint64_round_to_zero()
=== OUTPUT BEGIN ===
Checking PATCH 1/1: softfloat: Add float128_to_uint64_round_to_zero()...
ERROR: space prohibited after that open parenthesis '('
#38: FILE: fpu/softfloat.c:6129:
+ aSig1 = extractFloat128Frac1( a );
ERROR: space prohibited before that close parenthesis ')'
#38: FILE: fpu/softfloat.c:6129:
+ aSig1 = extractFloat128Frac1( a );
ERROR: space prohibited after that open parenthesis '('
#39: FILE: fpu/softfloat.c:6130:
+ aSig0 = extractFloat128Frac0( a );
ERROR: space prohibited before that close parenthesis ')'
#39: FILE: fpu/softfloat.c:6130:
+ aSig0 = extractFloat128Frac0( a );
ERROR: space prohibited after that open parenthesis '('
#40: FILE: fpu/softfloat.c:6131:
+ aExp = extractFloat128Exp( a );
ERROR: space prohibited before that close parenthesis ')'
#40: FILE: fpu/softfloat.c:6131:
+ aExp = extractFloat128Exp( a );
ERROR: space prohibited after that open parenthesis '('
#41: FILE: fpu/softfloat.c:6132:
+ aSign = extractFloat128Sign( a );
ERROR: space prohibited before that close parenthesis ')'
#41: FILE: fpu/softfloat.c:6132:
+ aSign = extractFloat128Sign( a );
ERROR: space prohibited after that open parenthesis '('
#42: FILE: fpu/softfloat.c:6133:
+ if ( aExp ) aSig0 |= LIT64( 0x0001000000000000 );
ERROR: space prohibited before that close parenthesis ')'
#42: FILE: fpu/softfloat.c:6133:
+ if ( aExp ) aSig0 |= LIT64( 0x0001000000000000 );
ERROR: trailing statements should be on next line
#42: FILE: fpu/softfloat.c:6133:
+ if ( aExp ) aSig0 |= LIT64( 0x0001000000000000 );
ERROR: braces {} are necessary for all arms of this statement
#42: FILE: fpu/softfloat.c:6133:
+ if ( aExp ) aSig0 |= LIT64( 0x0001000000000000 );
[...]
ERROR: space prohibited after that open parenthesis '('
#44: FILE: fpu/softfloat.c:6135:
+ if ( shiftCount <= 0 ) {
ERROR: space prohibited before that close parenthesis ')'
#44: FILE: fpu/softfloat.c:6135:
+ if ( shiftCount <= 0 ) {
ERROR: space prohibited after that open parenthesis '('
#45: FILE: fpu/softfloat.c:6136:
+ if ( 0x403E < aExp ) {
ERROR: space prohibited before that close parenthesis ')'
#45: FILE: fpu/softfloat.c:6136:
+ if ( 0x403E < aExp ) {
ERROR: space prohibited after that '!' (ctx:WxW)
#47: FILE: fpu/softfloat.c:6138:
+ if ( ! aSign
^
ERROR: space prohibited after that open parenthesis '('
#47: FILE: fpu/softfloat.c:6138:
+ if ( ! aSign
ERROR: space prohibited after that open parenthesis '('
#48: FILE: fpu/softfloat.c:6139:
+ || ( ( aExp == 0x7FFF )
ERROR: space prohibited before that close parenthesis ')'
#48: FILE: fpu/softfloat.c:6139:
+ || ( ( aExp == 0x7FFF )
ERROR: space prohibited after that open parenthesis '('
#49: FILE: fpu/softfloat.c:6140:
+ && ( aSig1 || ( aSig0 != LIT64( 0x0001000000000000 ) ) )
ERROR: space prohibited before that close parenthesis ')'
#49: FILE: fpu/softfloat.c:6140:
+ && ( aSig1 || ( aSig0 != LIT64( 0x0001000000000000 ) ) )
ERROR: space prohibited after that open parenthesis '('
#52: FILE: fpu/softfloat.c:6143:
+ return LIT64( 0xFFFFFFFFFFFFFFFF );
ERROR: space prohibited before that close parenthesis ')'
#52: FILE: fpu/softfloat.c:6143:
+ return LIT64( 0xFFFFFFFFFFFFFFFF );
ERROR: space prohibited after that '-' (ctx:WxW)
#56: FILE: fpu/softfloat.c:6147:
+ shortShift128Left( aSig0, aSig1, - shiftCount, &aSig0, &aSig1 );
^
ERROR: space prohibited after that open parenthesis '('
#56: FILE: fpu/softfloat.c:6147:
+ shortShift128Left( aSig0, aSig1, - shiftCount, &aSig0, &aSig1 );
ERROR: space prohibited before that close parenthesis ')'
#56: FILE: fpu/softfloat.c:6147:
+ shortShift128Left( aSig0, aSig1, - shiftCount, &aSig0, &aSig1 );
ERROR: else should follow close brace '}'
#58: FILE: fpu/softfloat.c:6149:
+ }
+ else {
ERROR: space prohibited after that open parenthesis '('
#59: FILE: fpu/softfloat.c:6150:
+ shift64ExtraRightJamming( aSig0, aSig1, shiftCount, &aSig0, &aSig1 );
ERROR: space prohibited before that close parenthesis ')'
#59: FILE: fpu/softfloat.c:6150:
+ shift64ExtraRightJamming( aSig0, aSig1, shiftCount, &aSig0, &aSig1 );
total: 30 errors, 0 warnings, 79 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
