Peter Maydell <peter.mayd...@linaro.org> writes: > On 31 January 2017 at 18:11, Daniel P. Berrange <berra...@redhat.com> wrote: >> On Tue, Jan 31, 2017 at 06:00:13PM +0000, Peter Maydell wrote: >>> We have attributes which we wrap in QEMU_ macros already >>> even though they always expand to the same thing: >>> QEMU_NORETURN and QEMU_ALIGNED. I'm happy to leave these >>> to follow that pattern. (If you wanted to send a patch >>> series that uninlined all of those then I wouldn't hugely >>> object to it, but I think it touches enough files that it's >>> a separate thing from removing the #if guards that this >>> patch does.) >> >> The other option is just to replace QEMU_WARN_UNUSED_RESULT with >> >> #define QEMU_WARN_UNUSED_RESULT G_GNUC_WARN_UNUSED_RESULT >> >> and convert code to use G_GNUC_WARN_UNUSED_RESULT directly until we >> can kill the QEMU specific define. There's no benefit to QEMU having >> its own defines that duplicate stuff already covered by our min >> required glib - G_GNUC_WARN_UNUSED_RESULT was added in 2.10 for >> example. > > I wouldn't object to that either, but again it ought to be > a different patch or patch series to this one...
I wouldn't exactly object, just say that to me, wrapping an attribute in a GLib-provided macro even though we're not aware of a compiler that profits from it feels a bit like "look ma, I've read all of the GLib manual!"
