On 31 January 2017 at 16:55, Daniel P. Berrange <berra...@redhat.com> wrote: > On Tue, Jan 31, 2017 at 04:14:47PM +0000, Peter Maydell wrote: >> We already require gcc 4.1 or newer (for the atomic >> support), so the fallback codepaths for older gcc >> versions than that are now dead code and we can >> just delete them. > > Do we have any explicit check alreadu for 4.1, or do we > just let the build fail on the atomic code ? > > IOW, is there any use in having.. > > #if !QEMU_GNUC_PREREQ(4, 1) > # error "QEMU requires GCC >= 4.1 or CLang" > #endif
I guess we just barf in the atomics. An explicit check might not be a bad idea I guess, though it depends a bit on how many releases we've been implicitly requiring 4.1 for. I suppose it would act as documentation of our current minimum req. thanks -- PMM
