Thanks for this bug report -- I have sent a patch making the proposed change: http://lists.nongnu.org/archive/html/qemu- devel/2017-01/msg05030.html
** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1658506 Title: qemu/hw/intc/arm_gicv3_cpuif.c:2433: bad expression ? Status in QEMU: In Progress Bug description: qemu/hw/intc/arm_gicv3_cpuif.c:2433]: (style) Expression '(X & 0x2000000000000000) == 0x1' is always false. Source code is ((lr & ICH_LR_EL2_HW) == 1 || (lr & ICH_LR_EL2_EOI) == 0)) { Maybe better code ((lr & ICH_LR_EL2_HW) != 0 || (lr & ICH_LR_EL2_EOI) == 0)) { To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1658506/+subscriptions