Paolo, There are several switches that need to be set for this module to work, and so - inspired by your comment - I decided to add a check for the necessary supporting switches before enabling the module. An error message is printed if everything is not as it should. I submitted the patch as v7.
Thanks for taking the time to review this. Jim -----Original Message----- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Monday, January 09, 2017 12:10 PM To: Nutaro, James J.; qemu-devel@nongnu.org Subject: Re: [PATCH v6] qqq: module for synchronizing with a simulation On 09/01/2017 18:04, Nutaro, James J. wrote: > Thanks again Paolo. When I change the command line switches, is it best to > submit a whole new version of the patch? Or is there another method for > managing patch revisions? Yes, submit a new version, then put v6->v7: did this and that [Paolo] at the end of the commit message, where the square brackets mean "suggested by...". Thanks, Paolo > > -----Original Message----- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, January 05, 2017 10:27 AM > To: Nutaro, James J.; qemu-devel@nongnu.org > Subject: Re: [PATCH v6] qqq: module for synchronizing with a simulation > > > > On 05/01/2017 16:07, James J. Nutaro wrote: >> This patch adds an interface for pacing the execution of QEMU to match an >> external >> simulation clock. Its aim is to permit QEMU to be used as a module within a >> larger simulation system. >> >> Signed-off-by: James J. Nutaro <nutar...@ornl.gov> > > What's the difference between v5 and v6? > >> +(2) Fork QEMU with the appropriate command line arguments. >> + The -qqq part of the argument will look something like >> + >> + -qqq sock=socks[1] > > No need for -qqq, just make it "-icount extclock=FD". > > Paolo >
