On 12/01/2017 18:10, Eduardo Habkost wrote:
> On Tue, Jan 10, 2017 at 03:07:31PM +0800, He Chen wrote:
>> AVX512_VPOPCNTDQ: Vector POPCNT instructions for word and qwords.
>> variable precision.
>>
>> Signed-off-by: He Chen <he.c...@linux.intel.com>
>> ---
>> target/i386/cpu.c | 2 +-
>> target/i386/cpu.h | 1 +
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index b0640f1..ae900b5 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -435,7 +435,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS]
>> = {
>> NULL, "avx512vbmi", "umip", "pku",
>> "ospke", NULL, NULL, NULL,
>> NULL, NULL, NULL, NULL,
>> - NULL, NULL, NULL, NULL,
>> + NULL, NULL, "vpopcntdq", NULL,
>
> The patches I see on linux-kernel use the "avx512_vpopcntdq"
> name. Why not use "avx512-vpopcntdq" in QEMU to avoid confusion?
Or without the dash too, for consistency with avx512vbmi.
Paolo
>
>> "la57", NULL, NULL, NULL,
>> NULL, NULL, "rdpid", NULL,
>> NULL, NULL, NULL, NULL,
>> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
>> index a7f2f60..73edc60 100644
>> --- a/target/i386/cpu.h
>> +++ b/target/i386/cpu.h
>> @@ -630,6 +630,7 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS];
>> #define CPUID_7_0_ECX_UMIP (1U << 2)
>> #define CPUID_7_0_ECX_PKU (1U << 3)
>> #define CPUID_7_0_ECX_OSPKE (1U << 4)
>> +#define CPUID_7_0_ECX_VPOPCNTDQ (1U << 14) /* POPCNT for vectors of DW/QW */
>> #define CPUID_7_0_ECX_LA57 (1U << 16)
>> #define CPUID_7_0_ECX_RDPID (1U << 22)
>>
>> --
>> 2.7.4
>>
>>
>
