On Thu, Jan 05, 2017 at 12:56:52AM +1000, Nathan Rossi wrote: > If libgcrypt info is available with pkg-config use it over using the > libgcrypt-config. pkg-config is preferred due to is compatibility with > cross-compilation (where you cannot execute the targets version of > libgcrypt-config).
It can be made to work, but you need to modify $PATH to ensure it finds the build target libgcrypt-config first. eg on Fedora you'd do this with mingw32 PATH=/usr/i686-w64-mingw32/sys-root/mingw/bin:$PATH ./configure ... > This change makes configure check for libgcrypt in pkg-config first, > then falling back to use libgcrypt-config if available. This follows a > similar process to how libsdl is handled. AFAIK, no version of libgcrypt has ever shipped a pkg-config file. Their maintainers have explicitly rejected patches adding that, ironically because they claim pkg-config doesn't handle cross-compilation and libgcrypt-config does :-) https://lists.gnupg.org/pipermail/gcrypt-devel/2007-February/001109.html https://lists.gnupg.org/pipermail/gcrypt-devel/2015-September/003569.html So overall, I don't think this patch is needed/desirable for QEMU. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
