Hi, On 16 August 2010 22:26, Janne Huttunen <jahut...@gmail.com> wrote: > Yes, your version works (both on paper and in practice). I'm not > quite sure I like the way it breaches the apparent abstraction > of the FIFO handling routines (if you can call it that) or the > way it first gives FIFO slots back to the guest but then rewinds > them back. Not that either of those concerns necessarily matter > much.
Since the incomplete commands are expected to be very rare compared to normal handling, I think the rewinding makes more sense logically. We also save some cycles this way. > > BTW, now that I look at it, if either HW_FILL_ACCEL or HW_RECT_ACCEL > is not set 'badcmd' will be called, but args won't be set (as far > as I can see). Isn't that wrong? Although I think the bug was there > even before your changes. Yeah, you're right. I added the missing args = 0; for those two cases and pushed the change. Cheers
