On Fri, 11/25 23:19, Yuval Shaia wrote: > diff --git a/slirp/tcpip.h b/slirp/tcpip.h > index 7bdb971..71eb6a6 100644 > --- a/slirp/tcpip.h > +++ b/slirp/tcpip.h > @@ -30,6 +30,8 @@ > * tcpip.h,v 1.3 1994/08/21 05:27:40 paul Exp > */ > > +#include "qemu/osdep.h" > +
It's a rule that sources in QEMU always include "osdep.h" first, so this is not necessary. There is a comment on this in scripts/clean-includes: ... # .h files will have redundant includes (including includes of osdep.h) # removed. ... Other headers that uses MAX() don't include it either. > #ifndef TCPIP_H > #define TCPIP_H