On 11/25/2016 04:31 AM, Jin Guojie wrote:
-#define LO_OFF (MIPS_BE * 4) -#define HI_OFF (4 - LO_OFF) +# define LO_OFF (MIPS_BE * sizeof(long)) +# define HI_OFF (sizeof(long) - LO_OFF)
For n32, sizeof(long) == 4, and for n64, sizeof(long) == 8. So in the end this change must be wrong for big-endian.
Surely using link_error, as my patch did, to assert at compile-time that these values were never used for TCG_TARGET_REGS == 64 is better.
r~
